POSYDON-code/POSYDON

Better handle of None objects

Aberta

#236 aberto em 9 de jan. de 2024

 (2 comentários) (0 reação) (1 responsável)Python (35 forks)auto 404
P3 - low priorityenhancementhelp wanted

Métricas do repositório

Stars
 (42 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

In the code an object is set to None, if not defined. This requires careful usage.

  1. Trying to access a sub-object/function, e.g. None.dtype will always fail. -> We always need to check for None before performing a sub-function or requesting a sub-object.
  2. Any mathematical operator will fail, if one of the variables is of NoneType. -> We shouldn't use None for any float or integer variables, but np.nan instead.

I'm not sure, whether there are other things, so feel free to add possible issues occurring from None objects! Maybe there are some functions, which don't work with None objects, but most should. Thus, whenever you add a new function (including ones imported from modules) check that they can handle Nones or make sure, that there is a check before in the code!

Guia do colaborador