"Download Now" button should respect the used installation method on Linux
#43.671 aberto em 14 de fev. de 2018
Métricas do repositório
- Stars
- (74.848 stars)
- Métricas de merge de PR
- (Mesclagem média 11h 43m) (1.000 fundiu PRs em 30d)
Description
Issue Type
Bug
Description
Edit: Originally this issue was specifically about the
.debinstallation method, but since this problem is not specific to it, I edited the issue to be more general.
How to reproduce
- Install (an outdated version of) VS Code using one of the installation methods.
- Open VSCode and wait for the
(1)to appear on the settings icon. - Click on the settings icon and then on Download Now.
Expected behavior
VSCode starts the download of the latest version's file (when the .tar.gz was used to install VS Code) or instructs the user to run an update through the relevant package manager.
Actual behavior
VS Code always starts the download of the latest version's .tar.gz file.
Possible solution
VS Code could check what type of download was used to install and behave differently based on that.
Checking whether a .deb was used could look something like this:
import { spawn } from 'child_process';
export function isDebInstallation(): Promise<boolean> {
return new Promise(resolve => {
spawn('dpkg', ['--list', 'code']).on('close', code => {
resolve(code === 0);
});
});
}
Another option would be to include the information about what installation method was used in the release.
VS Code Info
VS Code version: Code 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b, 2018-02-07T17:10:15.949Z) OS version: Linux x64 4.13.0-32-generic
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz (4 x 3300) |
| Load (avg) | 1, 1, 1 |
| Memory (System) | 15.61GB (10.31GB free) |
| Process Argv | /usr/share/code/code . |
| Screen Reader | no |
| VM | 0% |