GoogleContainerTools/skaffold

Load images into minikube rather than replacing host's docker env

Aberta

#4.654 aberto em 12 de ago. de 2020

 (2 comentários) (1 reação) (0 responsável)Go (1.416 forks)batch import
area/buildhelp wantedkind/feature-requestplatform/minikubepriority/p2

Métricas do repositório

Stars
 (12.822 estrelas)
Métricas de merge de PR
 (Mesclagem média 3d 6h) (16 fundiu PRs em 30d)

Description

currently in skaffold, if we detect a user has minikube as their active kubecontext, we run a minikube docker-env so that docker commands on the host machine build to minikube's docker daemon. this can cause issues if we're only trying to run a skaffold build while minikube is stopped - something that should be possible, but skaffold can't get around because it only knows to try and use minikube's docker daemon.

instead, we could use minikube cache add on images that are built locally, and do this on push, so builds will still work even when minikube's docker daemon is not accessible.

https://minikube.sigs.k8s.io/docs/handbook/pushing

Guia do colaborador