FuelLabs/sway

Subcurrency example possible changes

Open

#2.473 aberto em 8 de ago. de 2022

Ver no GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (5.421 forks)batch import
P: lowThe Sway Bookdocumentationgood first issue

Métricas do repositório

Stars
 (61.702 stars)
Métricas de merge de PR
 (Mesclagem média 22h 6m) (16 fundiu PRs em 30d)

Description

In the "send" function in the subcurrency example, it checks that the msg_sender() Address is the same as the address of the contract creator. This seems like faulty logic as that means only the contract creator can send tokens (ever). If for some reason this is the desired logic, i think theres still a change required which would be to use a internal function to avoid repeating this piece of code

let sender: Result<Identity, AuthError> = msg_sender();
let sender: Address = match sender.unwrap() {
    Identity::Address(addr) => {
        assert(addr == ~Address::from(MINTER));
        addr
},
    _ => {
        revert(0);
    },
};

Guia do colaborador