FreshRSS/FreshRSS
[Bug] Actualize lock files in a multi instance environment share the same path
Fechada
#6.370 aberto em 21 de abr. de 2024
Documentation :books:Good first issue 1️⃣Supporthelp wanted
Métricas do repositório
- Stars
- (15.022 estrelas)
- Métricas de merge de PR
- (Mesclagem média 11d 12h) (36 fundiu PRs em 30d)
Description
Describe the bug
Current installed version 1.23.1
In multi installation setup on hosted server where I have little agency instances running actualize cron jobs at same time share actualize lock files. Causing failed actualize job for every other instance after the first.
app/actualize_script.php:
$mutexFile = TMP_PATH . '/actualize.freshrss.lock';
I modified the "TMP_PATH . '/actualize.freshrss.lock';`" line to unique filenames per instance. And it solved my issue for now. However, I think this issue can cause problem for others.
To Reproduce
- Setup multiple instance.
- Setup cron actualize jobs to the same date.
- Check cron logs.
- See error in one: "FreshRSS feeds actualization was already running, so aborting new run..."
Expected behavior
Instances in the same environment installed different directory have different lock files.
FreshRSS version
Current installed version 1.23.1
Environment information
Installed on LAMP hosting service managed by Cpanel.
- PHP 7.4+
Additional context
No response