Comfy-Org/ComfyUI_frontend
[DevTask]: Run browser tests on Windows runner
Aberta
#3.197 aberto em 23 de mar. de 2025
enhancementhelp wanted
Métricas do repositório
- Stars
- (1.838 estrelas)
- Métricas de merge de PR
- (Mesclagem média 4d 21h) (881 fundiu PRs em 30d)
Description
Is there an existing issue for this?
- I have searched the existing issues and checked the recent builds/commits
What would your feature do ?
When developer uses Unix, and CI tests also all use Unix, changes are never tested on Windows. Running browser tests on Windows container during CI tests would resolve this lack of coverage.
Proposed workflow
- The workflows from comfyanonymous/ComfyUI or Comfy-Org/desktop are used to setup ComfyUI server in Windows container
- The
chromiumPlaywright project is run in the Windows runner
Additional information
Issues that could potentially have been caught if a Playwright tests were run on Windows runner:
- https://github.com/comfyanonymous/ComfyUI/pull/4801
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/2797
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/3196
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/2630
- https://github.com/comfyanonymous/ComfyUI/pull/4906 (maybe)
┆Issue is synchronized with this Notion page by Unito