CleverRaven/Cataclysm-DDA

Inconsistencies in inventory compare window

Open

#69.601 aberto em 21 de nov. de 2023

Ver no GitHub
 (4 comments) (1 reaction) (0 assignees)C++ (3.991 forks)batch import
Help WantedInfo / User InterfaceQuality of Life[C++]

Métricas do repositório

Stars
 (9.264 stars)
Métricas de merge de PR
 (Mesclagem média 6d 5h) (292 fundiu PRs em 30d)

Description

Describe the bug

The inventory compare window shows green/red text depending on which item is better/worse in that area. Some numbers are green on both sides, some are red on both sides. For instance, warmth/breathability is red on both, some bash and ballistic protections are both green, etc. Look at picture below and the expected behavior section here for all discrepancies. There may be some behind-the-scenes calculations that takes many factors into play for coloring each value. If so, it isn't clear what those could be.

Attach save file

N/A Trivially reproducible

Steps to reproduce

  1. Get two items, my picture shows "light survivor boots" and "steeltoed sneakers" and compare
  2. Notice that the coloring is wrong on some text.

Expected behavior

All specific examples of the problems in the image provided:

  1. The light survivor boots don't have a length (not sure if this is a bug or intended)
  2. Warmth for both items are red. I would expect the steeltoed sneakers to be green because it has +3 warmth vs the boots.
  3. Breathability should be green for the sneakers. I expect that means that you are less likely to sweat at higher temperatures, less generated fatigue from using that body part, stuff like that. (I could be wrong as to how it specifically functions, but thats how I interpret it)
  4. The "toes" bash protections for both items are green. I expect the higher value on the boots to be green, and sneakers to be red there.
  5. The "foot" has both Bash and Ballistic values green for both items, I expect the boots to be better in both protections

If there are protections that one armor has that the compared item doesn't, like a helmet and boots, having head and feet protections, I would probably expect them to be default gray since they can not be compared in those ways.

Screenshots

Untitled

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: eca466b [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Slowdown Fungal Growth [no_fungal_growth], Stats Through Skills [StatsThroughSkills] ]

Additional context

No response

Guia do colaborador