CakeML/cakeml

Remove mapPartial from mllist

Aberta

#1.449 aberto em 12 de ago. de 2026

 (0 comentário) (0 reação) (0 responsável)Standard ML (98 forks)auto 404
good first issuelow effort

Métricas do repositório

Stars
 (1.169 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

It seems that mllist redefines mapPartial which already exists in list:

listTheory.mapPartial_def;
val it =
   ⊢ (∀f. mapPartial f [] = []) ∧
     ∀f x xs.
       mapPartial f (x::xs) =
       case f x of NONE => mapPartial f xs | SOME y => y::mapPartial f xs:
   thm
> mllistTheory.mapPartial_def;
val it =
   ⊢ (∀f. mapPartial f [] = []) ∧
     ∀f h t.
       mapPartial f (h::t) =
       case f h of NONE => mapPartial f t | SOME x => x::mapPartial f t: thm

I ran into this issue after spending some time not understanding why mapPartial_def is not doing anything as I had an mllist as my ancestors.

I suspect the fix is basically as simple as just deleting the definition, with perhaps minor changes required here and there.

Guia do colaborador