BrighterCommand/Brighter

[Feature] UseOutboxArchiver should not require DbTransaction generic type

Open

#3.878 aberto em 23 de out. de 2025

Ver no GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (295 forks)batch import
.NET0 - BacklogBugV10.Xhelp wanted

Métricas do repositório

Stars
 (1.898 stars)
Métricas de merge de PR
 (Mesclagem média 8d 18h) (29 fundiu PRs em 30d)

Description

Is your feature request related to a problem? Please describe. While migrating to V10 i stumbled opon this issue:

// Proper UseOutboxArchiver invocation looks like this:
brighterBuilder.UseOutboxArchiver<DbTransaction>(new NullOutboxArchiveProvider(), options => options.MinimumAge = TimeSpan.FromDays(4));
// But that would require knowing the transaction type at compile time. And we don't, since there will be different transaction types for mongo and relational dbs.

Since we support using Postgres or MongoDB as a outbox provider - we cannot set the DbTransaction generic type during setting up the outbox archiver. I've found this workaround to work:

typeof(HostedServiceCollectionExtensions)
    .GetMethod(nameof(HostedServiceCollectionExtensions.UseOutboxArchiver))!
    .MakeGenericMethod(transactionType)
    .Invoke(null, [
        brighterBuilder,
        new NullOutboxArchiveProvider(),
        new Action<TimedOutboxArchiverOptions>(opt => opt.MinimumAge = TimeSpan.FromDays(4))
    ]);

The transactionType is passed down from microservice configuration and can be either mongo or postgres implementation. I think you are using similar logic when registering the outbox in AddProducers: https://github.com/BrighterCommand/Brighter/blob/fc3933f36b1f071bdb039e5b0f7856f430da3c75/src/Paramore.Brighter.Extensions.DependencyInjection/ServiceCollectionExtensions.cs#L166-L178

I think the same (or similar) logic can be performed in the UseOutboxArchiver helper (although i didn't analyze this to know for sure).

Describe the solution you'd like Ideally, UseOutboxArchiver should infer the transactionType automatically (i think it was the case in v9)

Guia do colaborador