psf/requests-html

Make pyppeteer use proxies

Open

#266 opened on Feb 18, 2019

View on GitHub
 (15 comments) (7 reactions) (0 assignees)Python (13,555 stars) (976 forks)batch import
enhancementgood first issue

Description

If you're using proxies with requests-html and rendering JS sites is all good. Once you render a website pyppeteer don't know about this proxies and will expose your IP. This is an undesired behavior when scraping with proxies.

The idea is that whenever someone passes in proxies to the session object or any method call, make pyppeteer also use these proxies. #265

Contributor guide

Tech stack
python
Domain
backenddata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of PythonFamiliarity with HTTP proxiesKnowledge of pyppeteer or headless browsers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the current proxy handling in requests html (likely in session.py) and how pyppeteer is invoked. Explore pyppeteer's launch options for proxy configuration. Check issue #265 for prior discussion and potential solutions. The goal is to pass proxy settings from requests html to pyppeteer when rendering JavaScript.