psf/requests-html

pyppeteer as optional dependency

Open

#182 opened on May 17, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (976 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (13,555 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

pyppeteer is a required dependency, but fails to build on PyPy3. How about making it an optional dependency?

Contributor guide

Research direction
Explore how to conditionally import pyppeteer and add it as an optional dependency in setup.py or pyproject.toml. Check existing patterns in the codebase for optional dependencies.
Tech stack
python
Domain
build system
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70