psf/requests-html

pyppeteer as optional dependency

Open

#182 opened on May 17, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (13,555 stars) (976 forks)batch import
enhancementgood first issue

Description

pyppeteer is a required dependency, but fails to build on PyPy3. How about making it an optional dependency?

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python packagingsetup.pyoptional dependencies
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine setup.py to find where pyppeteer is listed as a required dependency. Look for import statements of pyppeteer in the codebase and consider wrapping them in try except blocks to handle ImportError. Then modify setup.py to move pyppeteer to 'extras require' and update any documentation accordingly.