provectus/kafka-ui

FE: Handle 504s properly

Open

#4075 opened on Aug 1, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (7,799 stars) (977 forks)batch import
area/uxgood first issuescope/frontendstatus/acceptedtype/bug

Description

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running master-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

when kafka-ui can't access the remote broker, it waits for a long time (this should also have timeout). Meanwhile in the UI you see the loader in the topics page.

In the network tab I can see long request:

http://server/api/clusters/<cluster>/topics?page=1&perPage=25&showInternal=true

At some point it fails with 504, but the loader is still shown on the UI

Expected behavior

Loader should be removed and the error message should be shown

Your installation details

56fa824

Steps to reproduce

  1. make sure kafka ui can't access remote broker.
  2. visit topics page in that cluster

Screenshots

No response

Logs

no logs in the app output

Additional context

No response

Contributor guide

Tech stack
None
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic frontend developmentUnderstanding of HTTP error handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the frontend's API request handling, likely in the Topics page component. Look for where the loader is controlled and add error handling for 504 responses to display an error message instead of keeping the loader. Check if there is an existing error state pattern in the codebase, possibly in the network layer (e.g., axios interceptors) or within the component itself. Reference the commit 56fa824 if available.