provectus/kafka-ui

[Topics] Retention bytes custom parameter overrides the "Max size on disk in GB" value within Topic

Open

#3270 opened on Jan 26, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (7,799 stars) (977 forks)batch import
good first issuescope/frontendstatus/acceptedtype/bug

Description

Describe the bug (Actual behavior) When user is selecting "Max size on disk in GB" value (10 GB) and then add the Custom parameter "Retention bytes" with any value, after saving and editing the Topic, added custom parameter keeps and "Max size on disk in GB" value returns to "Not Set"

Expected behavior

  • If the "Max size on disk in GB" is selected, "Retention bytes" can be removed from Custom parameter dropdown values
  • If user lets "Max size on disk in GB" to be "Not set" or select any value (1, 10, 20, 50 GB) and then add the Retention bytes, after Topic save, the value of custom retention bytes can be displayed in "Max size on disk in GB" instead of "Not set"
  • Suggested to change "Max size on disk in GB" to be "Max size on disk "

Set up https://www.kafka-ui.provectus.io/

Steps to Reproduce

  1. Navigate to Topics
  2. Add required data
  3. Select "10 GB" for " "Max size on disk in GB"
  4. Add custom parameter
  5. Select retention bytes
  6. Fill value
  7. Save the Topic
  8. Press "Edit settings" from 3dot menu

Screenshots

https://user-images.githubusercontent.com/104780608/214736529-8e872422-685b-4eb4-92fe-09d74d64d03c.mov

Additional context relates to https://github.com/provectus/kafka-ui/issues/3071

Contributor guide

Tech stack
javareacttypescript
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Kafka topic configurationFamiliarity with React state management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the topic creation/edit form component in the frontend (likely located in the kafka ui/src/.../Topics/ directory). Identify how 'Max size on disk in GB' and custom parameter 'retention bytes' are stored and synchronized. Check for existing logic that handles the override behavior and consider implementing the expected behavior: either remove 'retention bytes' from custom parameters when 'Max size on disk' is set, or update the 'Max size on disk' field to reflect the custom retention bytes value. Review related issue #3071 for context. The fix should be localized to the topic form component and its state management.