protocolbuffers/protobuf

protoc --grpc_out should look on Windows path for grpc_cpp_plugin.exe

Open

#4,867 opened on Jul 5, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (16,128 forks)batch import
c++enhancementhelp wantedprotoc

Repository metrics

Stars
 (71,223 stars)
PR merge metrics
 (Avg merge 2d 11h) (185 merged PRs in 30d)

Description

What language does this apply to? Probably all, but I've only tried the cpp plugin

If it's a proto syntax change, is it for proto2 or proto3? Not syntax change

If it's about generated code change, what programming language? Not generated code change

Describe the problem you are trying to solve. On Windows, I have grpc_cpp_plugin.exe in my PATH. However, I cannot specify the plugin this way: $ protoc --grpc_out=. --plugin=protoc-gen-grpc=grpc_cpp_plugin.exe things_rpc.proto --grpc_out: protoc-gen-grpc: The system cannot find the file specified.

Describe the solution you'd like Search the PATH for plugins

Describe alternatives you've considered While I can specify the full path to plugin, it would be better to search PATH to make setting up build environments easier.

Contributor guide

Research direction
Investigate how protoc currently resolves plugin paths on Windows. Modify the plugin path resolution logic to search the PATH environment variable for the plugin executable name, falling back to the full path if provided. Look at the existing code for Unix plugin path handling for reference.
Tech stack
cpp
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++protobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70