protocolbuffers/protobuf

Dotnet - Include key name when failing to add to a MapField due to a duplicate key

Open

#17,085 opened on Jun 10, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (16,128 forks)batch import
help wanted

Repository metrics

Stars
 (71,223 stars)
PR merge metrics
 (Avg merge 2d 11h) (185 merged PRs in 30d)

Description

What language does this apply to? C#/dotnet

Describe the problem you are trying to solve. Trying to understand why adding a key to a MapField fails

Describe the solution you'd like The Argument exception should contain the name of the key that failed being added https://github.com/protocolbuffers/protobuf/blob/54d8f03974c108ef8fd0f26568cd9eb086165568/csharp/src/Google.Protobuf/Collections/MapField.cs#L97

Describe alternatives you've considered None

Additional context We aren't using this library directly, but through a 3rd party library that uses Google.Cloud.Logging.V2, making debugging challenging

Contributor guide

Research direction
Locate the MapField.Add method in the protobuf C# source and modify the ArgumentException to include the duplicate key name.
Tech stack
csharp
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90