protocolbuffers/protobuf

Build requires C++14, CMake doesn't set it

Open

#15,827 opened on Feb 13, 2024

View on GitHub
 (3 comments) (0 reactions) (1 assignee)C++ (16,128 forks)batch import
help wanted

Repository metrics

Stars
 (71,223 stars)
PR merge metrics
 (Avg merge 2d 11h) (185 merged PRs in 30d)

Description

What version of protobuf and what language are you using? Version: main Language: N/A

What operating system and version?

macOS Sonoma 14.3.1

What runtime / compiler are you using (e.g., python version or gcc version)

Apple clang version 15.0.0 (clang-1500.1.0.2.5)
Target: arm64-apple-darwin23.3.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

cmake version 3.28.3

What did you do?

Following the command from https://github.com/protocolbuffers/protobuf/blob/main/conformance/README.md:

$ cmake . -Dprotobuf_BUILD_CONFORMANCE=ON && cmake --build .

What did you expect to see

The conformance_test_runner binary is produced.

What did you see instead?

Many compilation errors, probably to do with not using -std=c++11.

Compilation output gist.

Contributor guide

Research direction
Inspect the CMakeLists.txt for the conformance target and add `set(CMAKE CXX STANDARD 14)` or `target compile features` to enable C++14.
Tech stack
cpp
Domain
backendbuild systemtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++CMakeGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70