prometheus/prometheus

tsdb benchmarks: create consistent way for periodic commits

Open

#15872 opened on Jan 28, 2025

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Go (64,042 stars) (10,408 forks)batch import
benchmarkcomponent/tsdbhelp wantedpriority/P3

Description

Just out of interest: In createHeadForBenchmarkSelect you added a commit every 1000 appends, here 100k*c appends are done. Is there a technical reason? No reason; I probably copied the 1000 from somewhere but can't find it now. There are many different styles, some of which look like errors, e.g. here. I agree it should be consistent but probably am not going to fix that today.

Originally posted by @bboreham in https://github.com/prometheus/prometheus/pull/15732#discussion_r1904380287

Contributor guide

Tech stack
go
Domain
testingperformance
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GoPrometheus TSDBbenchmarking
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Review the existing benchmark test files, particularly tsdb/querier test.go around line 3504, to identify all places where periodic commits are performed inconsistently. Then propose a unified helper function or constant that ensures a consistent commit interval across all TSDB benchmarks. Consult the PR discussion linked in the issue for context.