prometheus/prometheus

tsdb benchmarks: create consistent way for periodic commits

Open

#15,872 opened on Jan 28, 2025

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Go (10,408 forks)batch import
benchmarkcomponent/tsdbhelp wantedpriority/P3

Repository metrics

Stars
 (64,042 stars)
PR merge metrics
 (Avg merge 11d 5h) (118 merged PRs in 30d)

Description

Just out of interest: In createHeadForBenchmarkSelect you added a commit every 1000 appends, here 100k*c appends are done. Is there a technical reason? No reason; I probably copied the 1000 from somewhere but can't find it now. There are many different styles, some of which look like errors, e.g. here. I agree it should be consistent but probably am not going to fix that today.

Originally posted by @bboreham in https://github.com/prometheus/prometheus/pull/15732#discussion_r1904380287

Contributor guide

Research direction
Identify all benchmark functions in the tsdb package where periodic commits are performed inconsistently, then unify them to a consistent style (e.g., commit every N appends).
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80