project-chip/connectedhomeip

[CI/CD] Not all CI steps use the same warning levels when compiling

Open

#30,854 opened on Dec 6, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (6,410 stars) (1,659 forks)batch import
CI/CD improvementsgood first issuetools

Description

Looks like at least some of our CI / builders let through unused variables. We should turn this on everywhere. see https://github.com/project-chip/connectedhomeip/pull/30793/commits/d3752baacd322a78bcffae4d78fc2b0c64afe72f

Also...some let through code with missing semicolons somehow. I don't even know how that can happen, but see https://github.com/project-chip/connectedhomeip/pull/30793/commits/a14846a9aa48f5f8f8c06603a3ebd97e9c67b636

Contributor guide

Tech stack
ccpp
Domain
ci cdbuild system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ compiler flagsCI/CD configurationGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Identify all CI configuration files (e.g., .github/workflows, Makefile) where compiler flags are set. Ensure consistent use of Werror for unused variables and Werror for missing semicolons. Refer to PR #30793 commits for examples of flags that were missing. Check each CI step (Linux, Mac, Windows) and add the appropriate flags to the compiler invocations. Verify the changes do not break existing builds.