project-chip/connectedhomeip

[CI/CD] Not all CI steps use the same warning levels when compiling

Open

#30,854 opened on Dec 6, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (1,659 forks)batch import
CI/CD improvementsgood first issuetools

Repository metrics

Stars
 (6,410 stars)
PR merge metrics
 (Avg merge 8d 5h) (375 merged PRs in 30d)

Description

Looks like at least some of our CI / builders let through unused variables. We should turn this on everywhere. see https://github.com/project-chip/connectedhomeip/pull/30793/commits/d3752baacd322a78bcffae4d78fc2b0c64afe72f

Also...some let through code with missing semicolons somehow. I don't even know how that can happen, but see https://github.com/project-chip/connectedhomeip/pull/30793/commits/a14846a9aa48f5f8f8c06603a3ebd97e9c67b636

Contributor guide

Research direction
Identify which CI steps have lower warning levels and update their compiler flags to enforce Werror for unused variables and missing semicolons. Examine the provided commit references to see the specific changes needed.
Tech stack
ccpp
Domain
ci cdbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CI/CDC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40