probcomp/metaprob

Scorer for uniform distribution naively returns 1/(b-a) without checking if argument is in support

Open

#114 opened on Jan 29, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (16 forks)auto 404
buggood first issue

Repository metrics

Stars
 (170 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/probcomp/metaprob/blob/c1a01ea02c51ea0f8fedebd45954914d7645bde9/src/metaprob/distributions.clj#L55-L60

In the scorer, argument x should be checked to lie in the interval [a,b].

Contributor guide

Research direction
Inspect the scorer function for uniform distribution and add a check that x lies within the interval [a,b].
Tech stack
clojure
Domain
machine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitClojure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85