probcomp/bayeslite

pass query parameters through to metamodel syntax

Open

#446 opened on Jul 12, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (63 forks)batch import
help wantedk days

Repository metrics

Stars
 (915 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently we do not distinguish

CREATE GENERATOR g FOR p USING m ("foo")

from

CREATE GENERATOR g FOR p USING m ('foo')

which is not at the moment blocking anything (hence the stall of #410), but which may be worth fixing soon. Furthermore, passing a verbatim string through, e.g. to provide the source code in

CREATE GENERATOR g FOR p USING cgpm (
    MODEL x GIVEN y USING venturescript (source = 'assume x = 42; ...')
)

as we kludgily do in https://github.com/probcomp/bayeslite/blob/f3f27a584286a4f3f3a415a7935da6ea78bd9824/tests/test_vscgpm.py#L166-L179 with Python string formatting, is not easy to do reliably. That fragment just assumes no " appears in the VentureScript code, and abuses "..." quotation, which in SQL means names, with '...' meaning strings. No quotation should be necessary on the user's part -- it should be possible to do

bdb.execute('CREATE GENERATOR ... USING venturescript (source = ?) ...', (venturescript,))

and get the same intended effect reliably.

Contributor guide

Research direction
Investigate how SQL parameters (e.g., '?') are currently handled in the SQL parser and ensure they are properly passed through to the metamodel syntax, avoiding string literal abuse. Look at the grammar file and the handler for CREATE GENERATOR statements.
Tech stack
python
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SQLPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75