prettier/prettier

--range-{start,end} is ignored for --config-precedence=prefer-file

Open

#13354 opened on Aug 24, 2022

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (51,868 stars) (4,716 forks)batch import
area:cliarea:rangeshelp wantedtype:editor support

Description

Environments:

  • Prettier Version: 2.3.0
  • Running Prettier via: CLI
  • Runtime: v16
  • Operating System: Linux, macOS
  • Prettier plugins (if any):

Steps to reproduce:

  • Create file file.js
import {  a }  from 'a'  ;

import {b,  c  } from  'b-c';
  • Create file .prettierrc.js
module.exports = {}
  • Run cat file.js | prettier --stdin-filepath file.js --config-precedence=file-override --range-start 9 --range-end 10
import { a } from "a";

import {b,  c  } from  'b-c';
  • Run cat file.js | prettier --stdin-filepath file.js --config-precedence=prefer-file --range-start 9 --range-end 10
import { a } from "a";

import { b, c } from "b-c";

Expected behavior:

Both output should be the same.

Actual behavior:

--config-precedence=prefer-file ignores --range-start and --range-end flags.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Prettier configurationNode.js environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the CLI argument handling code in Prettier, specifically the logic that processes range start and range end flags in combination with config precedence. Look at how config precedence affects the parsing of these flags. Consider if the issue lies in the merge of CLI options and config file options. Files to examine: src/cli/constants.js, src/cli/options.js, or similar. Check existing comments in the issue for hints.