prettier/prettier

--range-{start,end} is ignored for --config-precedence=prefer-file

Open

#13,354 opened on Aug 24, 2022

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (4,716 forks)batch import
area:cliarea:rangeshelp wantedtype:editor support

Repository metrics

Stars
 (51,868 stars)
PR merge metrics
 (Avg merge 6d) (186 merged PRs in 30d)

Description

Environments:

  • Prettier Version: 2.3.0
  • Running Prettier via: CLI
  • Runtime: v16
  • Operating System: Linux, macOS
  • Prettier plugins (if any):

Steps to reproduce:

  • Create file file.js
import {  a }  from 'a'  ;

import {b,  c  } from  'b-c';
  • Create file .prettierrc.js
module.exports = {}
  • Run cat file.js | prettier --stdin-filepath file.js --config-precedence=file-override --range-start 9 --range-end 10
import { a } from "a";

import {b,  c  } from  'b-c';
  • Run cat file.js | prettier --stdin-filepath file.js --config-precedence=prefer-file --range-start 9 --range-end 10
import { a } from "a";

import { b, c } from "b-c";

Expected behavior:

Both output should be the same.

Actual behavior:

--config-precedence=prefer-file ignores --range-start and --range-end flags.

Contributor guide

Research direction
Examine the CLI option parsing code to see how ` range start` and ` range end` are applied when ` config precedence` is set to `prefer file`. The bug suggests file config overrides CLI range flags; verify the order of precedence logic.
Tech stack
javascript
Domain
clideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsPrettier CLI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70