prettier/prettier-atom

Doesn't work with global ESLint config

Open

#266 opened on Sep 13, 2017

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (764 stars) (106 forks)batch import
help wantedquestion

Description

linter-eslint has a global option for falling back to ~/.eslintrc config if no configs are found locally.

image

Your README says prettier-atom looks up system tree for configs, but it doesn't seem to be working.

Here's my prettier-atom config:

image image

Atom version: 1.19.7
prettier-atom version: 0.38.0
prettier version: 1.6.1
prettier-eslint version: 6.4.3
prettier-atom configuration: {
  "formatOnSaveOptions": {
    "enabled": true,
    "showInStatusBar": true,
    "respectEslintignore": true,
    "javascriptScopes": [
      "source.js",
      "source.jsx",
      "source.js.jsx",
      "source.babel",
      "source.js-semantic",
      "text.html.basic",
      "text.html.vue"
    ],
    "typescriptScopes": [
      "source.ts",
      "source.tsx",
      "source.ts.tsx"
    ],
    "cssScopes": [
      "source.css",
      "source.less",
      "source.css.less",
      "source.scss",
      "source.css.scss"
    ],
    "jsonScopes": [
      "source.json"
    ],
    "graphQlScopes": [
      "source.graphql"
    ],
    "excludedGlobs": [],
    "whitelistedGlobs": [],
    "isDisabledIfNotInPackageJson": false
  },
  "prettierOptions": {
    "singleQuote": true,
    "bracketSpacing": true,
    "semi": true,
    "useTabs": false,
    "jsxBracketSameLine": false,
    "printWidth": 80,
    "tabWidth": "auto",
    "trailingComma": "none",
    "parser": "babylon"
  },
  "useEslint": true,
  "useEditorConfig": true,
  "prettierEslintOptions": {
    "prettierLast": false
  }
}

It'd be nice if you could config to work with global .editorconfig as well.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of ESLint configurationFamiliarity with Atom package development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests support for global ESLint config fallback similar to linter eslint. Investigate how prettier atom currently resolves ESLint config files. The related code is likely in the ESLint integration module. Check the linter eslint package for reference on how global config is handled. Ensure that the fallback to ~/.eslintrc works when no local config is found. Also consider global .editorconfig support.
Doesn't work with global ESLint config · prettier/prettier-atom#266 | Good First Issue