prestodb/presto

[native] Remove DuckDB dependency for TaskManagerTest and from Prestissimo

Open

#22923 opened on Jun 5, 2024

View on GitHub
 (1 comment) (2 reactions) (1 assignee)Java (15,558 stars) (5,240 forks)batch import
feature requestgood first issue

Description

TaskManagerTest.cpp currently uses DuckDB to validate the results. This adds an additional dependency to Prestissimo. We must remove this. We must either modify the test to compare with expected values or use a Presto verifier.

Contributor guide

Tech stack
cpp
Domain
backendtesting
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ programmingPresto native testing environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue involves modifying TaskManagerTest.cpp located in the native code of Prestissimo to remove its DuckDB dependency. The test currently validates results using DuckDB; it should either compare with hardcoded expected values or integrate with the Presto verifier. Examine the Presto verifier documentation to understand how it can be used in native tests. The change is localized to this single test file and likely the CMakeLists.txt dependencies.