prestodb/presto

OutputMatcher should take a Collection rather than a List

Open

#22756 opened on May 15, 2024

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Java (15,558 stars) (5,240 forks)batch import
available-to-pickupgood first issueplanner

Description

com.facebook.presto.sql.planner.assertions.OutputMatcher should take a Collection rather than a List

Order is not important in this class so this is semantically correct, and I encountered a case where it would have been mildly more convenient to pass in a Set instead of a List.

Contributor guide

Tech stack
java
Domain
database
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaPresto codebase basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Locate the class OutputMatcher in the package com.facebook.presto.sql.planner.assertions. The goal is to change the method parameter type from List to Collection. Ensure that the change does not break any existing code or tests. Review the existing tests for OutputMatcher to confirm they still pass. Since an assignee is already set, check if there is any ongoing work or PRs linked to this issue.