prestodb/presto

OutputMatcher should take a Collection rather than a List

Open

#22,756 opened on May 15, 2024

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Java (5,240 forks)batch import
available-to-pickupgood first issueplanner

Repository metrics

Stars
 (15,558 stars)
PR merge metrics
 (Avg merge 34d 14h) (120 merged PRs in 30d)

Description

com.facebook.presto.sql.planner.assertions.OutputMatcher should take a Collection rather than a List

Order is not important in this class so this is semantically correct, and I encountered a case where it would have been mildly more convenient to pass in a Set instead of a List.

Contributor guide

Research direction
Locate the OutputMatcher class and change its method parameter from List to Collection. Update all callers that pass a List to accept a Collection instead. Ensure no other code relies on the order.
Tech stack
java
Domain
backenddatabase
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85