prestodb/presto

Exclude module-info.class from byte code checks

Open

#22,193 opened on Mar 13, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (5,240 forks)batch import
buildcleanupgood first issue

Repository metrics

Stars
 (15,558 stars)
PR merge metrics
 (Avg merge 34d 14h) (120 merged PRs in 30d)

Description

The build is full of these warnings:

[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53

This is not a surprise. module-info.class is something for java 9+ (byte code 53) while most of the build is Java 8 (byte code version 52).

This isn't a big deal since Java 8 will ignore module-info.class. There's no real problem here, but if anyone happens to know a straight-forward way to suppress these particular warnings that would be nice.

Contributor guide

Research direction
Investigate the build configuration (likely Maven) to find where bytecode version checks are performed. Determine how to exclude module info.class from those checks, possibly by configuring the maven bundle plugin or animal sniffer plugin, or by ensuring the build respects the module info class version.
Tech stack
java
Domain
backenddatabase
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMaven
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65