prestodb/presto

[native] Make "memory-pool-init-capacity" and "memory-pool-transfer-capacity" registered SystemConfig properties

Open

#21,345 opened on Nov 8, 2023

View on GitHub
 (4 comments) (1 reaction) (1 assignee)Java (5,240 forks)batch import
buggood first issue

Repository metrics

Stars
 (15,558 stars)
PR merge metrics
 (Avg merge 34d 14h) (120 merged PRs in 30d)

Description

memory-pool-init-capacity and memory-pool-transfer-capacity are not registered SystemConfig properties in https://github.com/prestodb/presto/blob/master/presto-native-execution/presto_cpp/main/common/Configs.cpp#L131

This leads to warnings ("Unregistered properties from ...") during server initialization. This is misleading.

These properties should be registered SystemConfig properties.

Steps to Reproduce

Add entries for memory-pool-init-capacity and memory-pool-transfer-capacity in config.properties and start Prestissimo

"memory-arbitrator-kind": "SHARED"
"memory-pool-init-capacity": "536870912"
"memory-pool-transfer-capacity": "536870912"

Contributor guide

Research direction
Add entries for memory pool init capacity and memory pool transfer capacity to the SystemConfig properties in presto native execution/presto cpp/main/common/Configs.cpp by following existing registration pattern.
Tech stack
cppjava
Domain
backenddatabaseinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Presto internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80