premake/premake-core

`os.findheader()` broken on macOS

Open

#873 opened on Aug 10, 2017

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)C (651 forks)auto 404
bugenhancementhelp wanted

Repository metrics

Stars
 (3,621 stars)
PR merge metrics
 (PR metrics pending)

Description

Opening an issue for this, as I'm not sure the best way to address it.

The current logic for building the include file search path on macOS results in Posix looking set of directories like /include:/usr/include:/usr/local/include.

On a typical macOS developer installation, the system headers will actually be installed to a path like /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/. If targeting iOS, the header would be in a directory like /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/usr/include/. The same for watchOS or tvOS.

It is not enough to identify the current system; the call must also know the target system to evaluate this call correctly.

Contributor guide

Research direction
Examine the search path logic in `os.findheader` on macOS and understand how Xcode SDK paths are structured. The issue requires handling target specific SDK locations (e.g., iOS, tvOS) rather than just the current system.
Tech stack
c
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CmacOS SDK paths
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60