premake/premake-core

os.findlib is not architecture aware

Open

#542 opened on Jul 14, 2016

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C (651 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (3,621 stars)
PR merge metrics
 (PR metrics pending)

Description

os.findlib may return the path to a 32bit lib even if the current project is configured to use the x86_64 architecture.

I am not really familiar with this but it seems to be possible to check for a compatible architecture/bitness by inspecting the file header.

Unix fifth byte of the ELF header

Value Bitness
1 32 bit
2 64 bit

Windows first two bytes of COFF header

Value Architecture
0x014c x86
0x8664 x64

Therefore one possibiliy would be to ignore incompatible files (and removing their path) until os.pathsearch returns a compatible file or nil.

Contributor guide

Research direction
Investigate how to read ELF/COFF headers from files to determine architecture bitness. Modify os.findlib to filter out incompatible libraries by checking the file header bytes described in the issue.
Tech stack
clua
Domain
build systemdevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Cbinary file parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60