preactjs/preact-router

Problems with link anchors

Open

#260 opened on Jan 10, 2018

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (152 forks)github user discovery
has fixhelp wanted

Repository metrics

Stars
 (1,055 stars)
PR merge metrics
 (PR metrics pending)

Description

Whenever I click on a anchor link (for example 'href="#123"'), this

addEventListener('popstate', function () {
				routeTo(getCurrentUrl());
			});

fires and reloads the according route component, what some-have screws up the anchor and anyways is redundant.

Contributor guide

Research direction
Investigate the popstate event listener in the router code and determine why anchor link clicks trigger it. Ensure that the router does not re route on same page anchors.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75