preactjs/preact-compat

child visible property toggles from true to false without re-render

Open

#311 opened on Feb 28, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (952 stars) (148 forks)batch import
help wanted

Description

In my test project: https://github.com/MichaelRando/preact-rollup-bootstrap pressing button 'Test Dialog' displays a test dialog, by virtue of setting the state variable to true and the Dialog's visible property is set to said state. Clicking off or closing the dialog is expected to hide the dialog's view. When using react & react-dom, the dialog appears and disappears as many times as the user could want, successfully. When using preact & preact-compat, the dialog appears successfully, but closing / setting the visible state false has no effect. The Dialog component is not re-rendering as React compatibility would expect. This is a super basic test; not sure why this is happening.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsPreact compatible components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the dialog visibility toggle bug in preact compat by reviewing the 8 comments for debugging hints. The linked test project (github.com/MichaelRando/preact rollup bootstrap) reproduces the issue. Compare how preact compat handles child visibility vs. React. The compatibility layer has since moved to the main preact repo; check if the bug persists there and consider porting the fix.