preactjs/preact-cli

manifest.json extension change

Open

#724 opened on Feb 7, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4,674 stars) (415 forks)batch import
enhancementhelp wantedmaybe

Description

Do you want to request a feature or report a bug? A very nitpicky Feature

What is the current behaviour? preact-cli and its given templates seem to favour manifest.json over manifest.webmanifest. And it works great!

If the current behaviour is a bug, please provide the steps to reproduce. N/A

What is the expected behaviour? manifest.json to use the webmanifest extension (manifest.webmanifest)

If this is a feature request, what is motivation or use case for changing the behaviour? The W3 spec somewhat recently confirmed that they favour the webmanifest extension for app manifests

Please mention other relevant information. N/A

Contributor guide

Tech stack
javascriptnodejs
Domain
frontendcli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of web manifestsfamiliarity with preact cli templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue requests changing the manifest file extension from .json to .webmanifest. Currently, preact cli templates use 'manifest.json'. To implement, locate the template files (likely in 'template/' directory) and update the filename to 'manifest.webmanifest'. Also check any references to the manifest in the CLI source code (e.g., in 'src/' or configuration files) to ensure they point to the new extension. No existing PRs or comments provide further details, so the solution is straightforward.
manifest.json extension change · preactjs/preact-cli#724 | Good First Issue