`check-shebang-scripts-are-executable` Assumes Git Repo

Open
#749 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, python
Domain
cli, tooling

Research direction

Locate the implementations and tests for check-shebang-scripts-are-executable and compare them with check-executables-have-shebangs, beginning with how each hook handles paths outside a Git repository. Done means the executable-checking hook works outside Git and its behavior is covered by tests for filesystem executable bits.

Written by the indexing model from the issue text.

Description

check-executables-have-shebangs supports being run on files outside of a Git repository, so it seems natural for check-shebang-scripts-are-executable to do the same. I would guess it's also slightly faster to check executable bits through the file system when it can be trusted to track them properly.

Dominant language
Python
Stars
6.7k
Forks
800
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pre-commit/pre-commit-hooks

All issues in pre-commit/pre-commit-hooks

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.