spaces on selectors (or containers in general) don't work
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- tooling
Research direction
Start with the parser construction and .toString() example in the issue, then trace how selector containers and their spaces values are serialized. Reproduce the :not case and determine how container-level spacing should be represented so the output preserves the requested spaces; add coverage for that behavior.
Written by the indexing model from the issue text.
Description
parser
.pseudo({
value: ':not',
nodes: [
selectorParser.selector({
nodes: [selectorParser.tag({ value: 'span' })],
spaces: { before: ' ', after: ' ' },
}),
selectorParser.selector({
nodes: [selectorParser.tag({ value: 'span' })],
spaces: { before: ' ', after: ' ' },
}),
],
})
.toString() // ':not(span,span)'
I think the idea is that the spaces go on the nodes, but that's a bit unwieldy of an API when walking through the or transforming selectors, since you drill down and find the first non-container thing to apply spacing too.
- Dominant language
- JavaScript
- Stars
- 214
- Forks
- 63
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from postcss/postcss-selector-parser
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
-
postcss/postcss-selector-parser#332 · 1 reaction · 2 assignees ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
postcss/postcss-selector-parser#309 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
postcss/postcss-selector-parser#306 · 2 comments ·
All issues in postcss/postcss-selector-parser
Similar issues
-
bug confirmed issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
open-webui/open-webui#30750 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Mend: dependency security vulnerability untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 70/100