Button component forces users to override `font-family` with `!important`

Open Beginner friendly
#12,758 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Start in base/browser/ui/positronComponents/button/button.tsx and inspect the Button styles around the font-family declaration. Compare the behavior with the CellTextOutput.css example, then verify that consumers can set their intended font without !important and that the styling still applies correctly to Button children.

Written by the indexing model from the issue text.

Description

area: ui tidiness

The Button component in base/browser/ui/positronComponents/button/button.tsx sets font-family: unset !important in its styles. This forces consumers to use !important to override the font, which can be confusing and propagates through to all children.

Example: CellTextOutput.css needs font-family: system-ui, sans-serif !important on .notebook-output-truncation-message.

Dominant language
TypeScript
Stars
4.3k
Forks
184
Avg merge
1d 5h
Merged PRs (30d)
186

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from posit-dev/positron

All issues in posit-dev/positron

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.