test: Don't expect_error() without asserting the message
@toph-allen is already working on this.
Since Dec 20, 2024.
Assessment
This issue has not been assessed yet.
Description
I fixed one issue recently where there was a syntax error in the error message construction, so instead of showing the expected message, it was showing a string interpolation error. But the test we had for that case was just doing expect_error(), so it was passing. We should generally assert something about the error message so that we know the expected error is happening.
- Dominant language
- R
- Stars
- 54
- Forks
- 27
- Avg merge
- 1d 3m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from posit-dev/connectapi
-
Difficulty 1/5 Under an hour Newbie friendliness 62/100
posit-dev/connectapi#249 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
posit-dev/connectapi#527 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
posit-dev/connectapi#526 · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
posit-dev/connectapi#506 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
posit-dev/connectapi#486 ·
All issues in posit-dev/connectapi
Similar issues
-
documentation pkg infrastructure
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
epiverse-trace/epiparameter#511 ·
-
function:write_dwc
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Urgent request: Due to vulnerabilities move to API version 12.6.1 (12.6.2 eventually) or 13.1.1 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jbkunst/highcharter#849 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100