pockethub/PocketHub

Architecture

Open

#1,160 opened on Feb 23, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Java (9,401 stars) (3,521 forks)batch import
discussionhelp wanted

Description

As it stands the app mixes a lot of UI and network code. I makes it hard to understand the flow and to see where to UI changes are made. Other problems include huge files, IssueFragment is a good example.

I'm open to suggestions to how we can fix this.

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Android developmentJavaPocketHub codebase familiaritySoftware architecture patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the current codebase structure, focusing on IssueFragment and other large files that mix UI and network code. Review comments in the issue for suggestions. Propose a clean architecture pattern (e.g., MVP or MVVM) to separate concerns. Look at how network calls are handled and suggest a refactor plan.