[CHORE]: Remove `Plotly.Snapshot.toImage`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript
- Domain
- data-visualization
Research direction
Start with src/snapshot/toimage.js and the references at src/snapshot/index.js:11, devtools/test_dashboard/devtools.js:86, and src/snapshot/svgtoimg.js. Trace how the public API is exposed through src/core.js and confirm there are no remaining callers under src/. Done means the implementation and existing references are removed consistently, with the breaking-change and deprecation decision resolved for the next major release.
Written by the indexing model from the issue text.
Description
Description
Remove Plotly.Snapshot.toImage and its implementation in src/snapshot/toimage.js.
Why should this change be made?
Plotly.toImagereplaced it in 2016 (642ddbaee5)- The old function has no caller under
src/and no test coverage
Scope
- Delete
src/snapshot/toimage.js - Update/remove the existing references (
src/snapshot/index.js:11,devtools/test_dashboard/devtools.js:86,src/snapshot/svgtoimg.js)
Notes
- This is a breaking change, so save it for the next major release
- This removes a public API through
exports.Snapshotinsrc/core.js - We could add a deprecation notice first
- Dominant language
- JavaScript
- Stars
- 18.3k
- Forks
- 2k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 21
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plotly/plotly.js
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
chore P3 plotly-internal size: 3 task
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
chore P1 plotly-internal size: 1 task
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
chore P3 plotly-internal size: 1 task
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
plotly/plotly.js#7648 · 3 comments ·
Maintainers usually reply within 1 day
All issues in plotly/plotly.js
Similar issues
-
agent/quality hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 78/100
jaegertracing/jaeger-ui#4512 ·
Maintainers usually reply within 1 day
-
feedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
githubnext/gh-aw-workshop#3857 ·
Maintainers usually reply within 2 days
-
area-clientside-dartpad
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
quarkusio/extensions#3432 ·
Maintainers usually reply within 1 day