Could subplot have explicit error when ncols is passed?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- r
- Domain
- data-visualization
Research direction
Start by reproducing the supplied R example at the subplot entry point and inspect how the ncols argument is handled. Done means passing ncols no longer produces the subscript-out-of-bounds error and instead gives a clear, intentional message; consider the existing subplot behavior described in the issue when checking the result.
Written by the indexing model from the issue text.
Description
I just tried to use subplot in a shiny app, and naively assumed that there would be an ncols argument corresponding to nrows - evidently, that is not really needed, but an error message clearer than Error in [[: subscript out of bounds would have saved me a lot of confusion. Might still be worth making this explicit? (Or - though that might be too much of a change - require all ... arguments to be unnamed?)
library(plotly)
p1 <- plot_ly(economics, x = ~date, y = ~uempmed)
p2 <- plot_ly(economics, x = ~date, y = ~unemploy)
subplot(p1, p2, ncols = 2)
#> Error in plots[[i]][["frames"]]: subscript out of bounds
Created on 2024-05-09 with reprex v2.0.2
- Dominant language
- R
- Stars
- 2.7k
- Forks
- 641
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plotly/plotly.R
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
-
save_image Error Open
Difficulty 3/5 1-2 days Newbie friendliness 52/100
Similar issues
-
area:livestock bug priority:low
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
eduaguilera/whep#1313 ·
-
rules
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
The-Strategy-Unit/nhp_reskit#229 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
epiforecasts/EpiNow2#1547 ·