plotly/falcon

Refactor Preview.react.js and Settings.react.js

Open

#362 opened on Feb 1, 2018

View on GitHub
 (15 comments) (1 reaction) (0 assignees)JavaScript (5,093 stars) (279 forks)batch import
discussiongood first issuehelp wantedrefactor

Description

cc/ @kcolton @chriddyp @tarzzz

I'm starting this discussion prompted by issues:

  • #360 (poor performance of code editor)
  • #361 (duplicated sql-schemas requests)

Although the code editor lives in CodeEditorField.react.js and the schema preview in TableTree.react.js, it's very likely that we'll have to touch code in their parent components Preview.react.js and Settings.react.js.

I'd like to use this issue to discuss any significant changes to Preview.react.js and Settings.react.js before creating a PR.

Contributor guide

Tech stack
javascriptreact
Domain
frontendperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the performance issues described in #360 and #361. Review the code in Preview.react.js and Settings.react.js along with their child components CodeEditorField.react.js and TableTree.react.js. Identify how to eliminate duplicated SQL schema requests and improve code editor performance. Consider proposing a refactoring plan in this issue before coding.