plotly/falcon

Refactor Preview.react.js and Settings.react.js

Open

#362 opened on Feb 1, 2018

View on GitHub
 (15 comments) (1 reaction) (0 assignees)JavaScript (279 forks)batch import
discussiongood first issuehelp wantedrefactor

Repository metrics

Stars
 (5,093 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

cc/ @kcolton @chriddyp @tarzzz

I'm starting this discussion prompted by issues:

  • #360 (poor performance of code editor)
  • #361 (duplicated sql-schemas requests)

Although the code editor lives in CodeEditorField.react.js and the schema preview in TableTree.react.js, it's very likely that we'll have to touch code in their parent components Preview.react.js and Settings.react.js.

I'd like to use this issue to discuss any significant changes to Preview.react.js and Settings.react.js before creating a PR.

Contributor guide

Research direction
Analyze Preview.react.js and Settings.react.js, trace data flow to child components like CodeEditorField and TableTree. Review issues #360 and #361 to understand performance concerns and duplicated requests. Investigate state management and props passing to identify refactoring opportunities to improve performance and reduce redundancy.
Tech stack
javascriptreact
Domain
frontenddesktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60