apps update step fails with de-client>=1.10.0 when group_co_owners / group_viewers inputs are not set
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Inspect the post-deploy step in action.yml around lines 155-165, along with the group_co_owners and group_viewers input definitions. Reproduce the workflow with de_client_version 1.10.0 and no group inputs, then make the group flags conditional and correct the input types to string. Done means the workflow succeeds without either group input and still accepts non-empty group values.
Written by the indexing model from the issue text.
Description
The post-deploy step in action.yml (https://github.com/plotly/de-deploy/blob/main/action.yml#L155-L165) always invokes:
de --no-keyfile apps update --name $APP_NAME \
--add-group-co-owner "${{ inputs.group_co_owners }}" \
--add-group-viewer "${{ inputs.group_viewers }}"
When neither input is provided, this expands to literal empty strings:
de --no-keyfile apps update --name de5-de-deploy --add-group-co-owner "" --add-group-viewer ""
With de-client==1.9.5 this was a silent no-op. With de-client==1.10.0, the CLI now strictly validates group names and exits 1:
Error updating app [de5-de-deploy]: Group '' could not be found on <host>.
Error: Process completed with exit code 1.
Repro:
any workflow using plotly/de-deploy@main with de_client_version: '1.10.0' and no group_co_owners / group_viewers inputs.
Proposed fix:
make the flags conditional on the inputs being non-empty, e.g.:
args=()
[[ -n "${{ inputs.group_co_owners }}" ]] && args+=( --add-group-co-owner "${{ inputs.group_co_owners }}" )
[[ -n "${{ inputs.group_viewers }}" ]] && args+=( --add-group-viewer "${{ inputs.group_viewers }}" )
if (( ${#args[@]} > 0 )); then
de --no-keyfile apps update --name "${{ steps.app_name.outputs.app_name }}" "${args[@]}"
fi
On the side:
input type typos in action.yml — group_viewers.type: strong and group_co_owners.type: boolean should both be string.
- Dominant language
- No language data
- Stars
- 4
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from plotly/de-deploy
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Add support for DE4 Open
All issues in plotly/de-deploy
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
repo:raw-data
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
hotosm/raw-data-api#316 · 1 comment ·
-
agentic-workflows cascade-suspected
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
willow
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
openedx/openedx-authz#460 ·