plopjs/plop

Append unique with '*' character

Open

#275 opened on Jul 21, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (6,845 stars) (266 forks)batch import
buggood first issue

Description

I'm having trouble getting the append action to replace duplicate entries with the unique property in the following scenario:

// index.js template
/* PLOP_INJECT_EXPORT */
export * from './foo';

// plopfile.js action definition
ACTION: {
  type: 'append',
  data: {},
  path: indexFilePath,
  template: "export * from './foo';",
  pattern: '/* PLOP_INJECT_EXPORT */',
  unique: true,
}

// index.js file result
/* PLOP_INJECT_EXPORT */
export * from './foo';
export * from './foo';

Do you have any suggestions on how to get unique working in this situation?

This appears to be related to issue https://github.com/plopjs/plop/issues/174 which was closed.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
plop's append actionregular expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `append` action implementation in plop, likely in `src/actions/append.js`. The `unique` option probably checks if the exact template string already exists in the file, but the `*` character may be causing a false mismatch due to escaping or newline handling. Compare the template string with the existing content line by line or using exact match. Also review the closed issue #174 for context. Reproduce the issue using the provided example and examine the comparison logic for `unique`.