playframework/playframework

`Play.XML` should use ThreadLocal SAXParser

Open

#6,939 opened on Feb 4, 2017

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Scala (4,032 forks)batch import
help wanted

Repository metrics

Stars
 (12,623 stars)
PR merge metrics
 (Avg merge 10d 17h) (69 merged PRs in 30d)

Description

Apache xerces uses a lot of Class.forName to create SaxParser object, which will call ClassLoader.loadClass for every xml parsing.

And this will block each other, then leads to bad performance for a high load system.

Contributor guide

Research direction
Research the Play.XML module, understand how SAXParser is currently created, and implement ThreadLocal caching to reuse parsers. Ensure thread safety and consider performance testing.
Tech stack
javascala
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaXMLPlay Framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65