playcanvas/engine

BoundingBox, BoundingSphere, OrientedBox extra methods.

Open

#858 opened on Feb 22, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (8,878 stars) (1,325 forks)batch import
enhancementgood first issue

Description

It worth finalizing consistency withing those three classes, so here is list of things to do:

BoundingBox

  1. Deprecate intersects and add another method intersectsBoundingBox which will have same functionality
  2. Add intersectsOrientedBox method
  3. Add center and halfExtents property reference

BoundingSphere

  1. Add intersectsBoundingBox method (calls box.intersectsBoundingSphere internally)
  2. Add intersectsOrientedBox method
  3. Add center and radius property reference

OrientedBox

  1. Add intersectsBoundingBox method (calls box.intersectsOrientedBox internally)
  2. Add intersectsOrientedBox method
  3. Add halfExtents property reference
  4. Property worldTransform has wrong reference

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic 3D geometryJavaScriptFamiliarity with PlayCanvas engineUnderstanding of bounding volumes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Locate the BoundingBox, BoundingSphere, and OrientedBox classes in the PlayCanvas engine codebase (likely in src/scene/). Review existing methods like intersects, intersectsBoundingSphere, and property references. For BoundingBox: deprecate intersects and add intersectsBoundingBox (same functionality), add intersectsOrientedBox, and add center and halfExtents property references. For BoundingSphere: add intersectsBoundingBox (calling box.intersectsBoundingSphere internally), add intersectsOrientedBox, and add center and radius property references. For OrientedBox: add intersectsBoundingBox (calling box.intersectsOrientedBox), add intersectsOrientedBox, add halfExtents property reference, and fix the worldTransform property reference. Ensure consistency and follow existing coding patterns. Check for any existing implementations or partial work.