Add a launcher start method and event to access the Window object

Open Beginner friendly
#2,153 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Start at the launcher startup path shown in the issue, where window.open creates the launcher and editor.call("launcher:start", launcher) is triggered. Trace how launcher methods and events are exposed, then add the requested start method and event so the opened Window object is accessible through the clearer API. Done means the API is available when the launcher starts.

Written by the indexing model from the issue text.

Description

area: launch tab enhancement

A new method and event should be added when the launcher starts so that the Window object can be accessed. At the moment, editor.call("launcher:start", launcher) is triggered here, but a clearer and more convenient API is needed to work with the opened window.

        const features = popup ? 'popup' : undefined;
        const launcher = window.open('', '_blank', features);
        if (launcher) {
            launcher.opener = null;
            launcher.location = url;
            editor.call("launcher:start", launcher); // Fire event
        }
Dominant language
TypeScript
Stars
1.3k
Forks
215
Avg merge
1d 29m
Merged PRs (30d)
30

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from playcanvas/editor

All issues in playcanvas/editor

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.