Eliminate double download of assets and orders

Open
#1,010 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Inspect the changes from PR #1002 around the two referenced locations, lines 600 and 620, and trace the calls that download the asset or order. Confirm which request obtains the Content-length header, then verify that the fix avoids the second download while preserving the initial connection.

Written by the indexing model from the issue text.

Description

bug data api orders api sdk-2023.7

#1002 unintentionally introduces a double download. One at https://github.com/planetlabs/planet-client-python/pull/1002/files#diff-eb40861f30b566f7a4a569eb3e052b9edccf30400cbe3a309c34f914aab79cd1R600 and one at https://github.com/planetlabs/planet-client-python/pull/1002/files#diff-eb40861f30b566f7a4a569eb3e052b9edccf30400cbe3a309c34f914aab79cd1R620. The implementation of #1002 only requires the first to be an initial connection to get the Content-length header. We may want to change the implementation, but changing the get to stream is a good enough fix for the moment.

Dominant language
Python
Stars
299
Forks
100
Avg merge
7d 8h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from planetlabs/planet-client-python

All issues in planetlabs/planet-client-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.