piskvorky/gensim

Move BrownCorpus from word2vec to gensim.corpora

Open

#2,956 opened on Sep 24, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (15,144 stars) (4,349 forks)batch import
good first issuehousekeeping

Description

Not a high-priority at all, but it'd be more sensible for such a tutorial/testing utility corpus to be implemented elsewhere - maybe under /test/ or some other data- or doc- related module – rather than in gensim.models.word2vec.

Originally posted by @gojomo in https://github.com/RaRe-Technologies/gensim/pull/2939#discussion_r493820305

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythongensim package structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
BrownCorpus is currently in gensim/models/word2vec.py. It should be moved to the gensim/corpora/ module. Update the class and all imports across the codebase, including tests. Refer to the discussion in PR #2939 for rationale: https://github.com/RaRe Technologies/gensim/pull/2939#discussion r493820305.