piskvorky/gensim

proper check for filename before calling subprocess

Open

#1485 opened on Jul 14, 2017

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Python (15,144 stars) (4,349 forks)batch import
Hacktoberfestbugdifficulty mediumgood first issue

Description

Based on discussion here, we should properly check for filename before process calls in utils.check_output(), and raise more intuitive exception and error message.

cc @jayantj

Contributor guide

Tech stack
python
Domain
datadeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythongensimsubprocess
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue requires modifying the `check output` function in `gensim/utils.py` to validate the filename before calling subprocess. The current implementation may call subprocess with an invalid filename, leading to a cryptic error. The fix should check if the filename is valid (e.g., exists or is a string) and raise a meaningful exception like `FileNotFoundError` with a clear message. The Google Groups discussion linked in the issue provides context on the expected behavior.