pinpoint-apm/pinpoint

MatchableClassFileTransformerDispatcher not apply on All Classes

Open

#3,687 opened on Jan 8, 2018

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Java (13,194 stars) (3,735 forks)batch import
help wantedmodule:plugin

Description

Description

I wrote KafkaConsumer plugin，then a very strange thing happens. I have print out all the MatchableClassFileTransformerGuardDelegate . And I can see 'SubscriptionState' class has a MatchableClassFileTransformerGuardDelegate transformer {matcher=DefaultClassNameMatcher{org.apache.kafka.clients.consumer.internals.SubscriptionState}, transformCallback=com.navercorp.pinpoint.plugin.kafka.KafkaClientPlugin$1@3dd6db4a} But The transformer has not been applied. (Noexception happens of course) Similar like https://stackoverflow.com/questions/34285862/java-agent-transform-not-applied-on-all-classes

Contributor guide

Tech stack
java
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Java agent basicsPinpoint plugin developmentClass file transformer concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the MatchableClassFileTransformerDispatcher and how transformers are applied during class loading. Compare with the StackOverflow issue linked. Check the KafkaClientPlugin registration of transformer for 'SubscriptionState' class. Look at the class loader hierarchy and ensure the agent is transforming classes loaded by the correct class loader. Review the comments for any additional clues.
MatchableClassFileTransformerDispatcher not apply on All Classes · pinpoint-apm/pinpoint#3687 | Good First Issue