pinojs/pino

bindings() and setBindings() are not present in the browser version of pino

Open

#1,177 opened on Oct 20, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (13,157 stars) (839 forks)batch import
enhancementgood first issue

Description

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

Contributor guide

Tech stack
javascript
Domain
backendfrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with pino's APIknowledge of child logger behavior
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by examining the browser.js file in the repository to understand how the browser logger is implemented. Check the documentation for bindings() and setBindings() in the Node.js version. Look at how child loggers are created and if bindings are mutable. The issue author requested guidance, so it would be helpful to review any comments for additional context.