pinojs/pino-http

Bug: `customErrorMessage` actually got passed 4 arguments, but it's ts declaration only has 3 arguments

Closed

#359 opened on Nov 25, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (128 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (694 stars)
PR merge metrics
 (Avg merge 1m) (2 merged PRs in 30d)

Description

customErrorMessage actually got passed 4 arguments: https://github.com/pinojs/pino-http/blob/8baaeec6fa2b53a7fe1c6bb948b3f46b7dbb6bdf/logger.js#L123 , but its ts declaration only has 3 arguments: https://github.com/pinojs/pino-http/blob/8baaeec6fa2b53a7fe1c6bb948b3f46b7dbb6bdf/index.d.ts#L34

I'd like to make use of the 4th argument "responseTime" in my logging message.

Contributor guide

Research direction
Update the TypeScript declaration file to include an optional fourth parameter for responseTime in the customErrorMessage callback.
Tech stack
javascripttypescriptnodejs
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70